Reference security-category table columns by header text#1052
Merged
labkey-chrisj merged 2 commits intodevelopfrom Oct 1, 2025
Merged
Reference security-category table columns by header text#1052labkey-chrisj merged 2 commits intodevelopfrom
labkey-chrisj merged 2 commits intodevelopfrom
Conversation
labkey-martyp
approved these changes
Oct 1, 2025
Contributor
labkey-martyp
left a comment
labkey-martyp
left a comment
There was a problem hiding this comment.
The change looks good to me. I kicked off a few more runs on TC to test flakiness.
Contributor
Author
|
Here's a link to my run in this branch: https://teamcity.labkey.org/buildConfiguration/LabkeyTrunk_EhrSqlserver?branch=category_security_table_columns |
Contributor
|
I also ran just the SND suite a few more times and they all passed. https://teamcity.labkey.org/buildConfiguration/LabKey_Trunk_LabkeyPremiumTrunk_GitModules_SndSqlserver?branch=category_security_table_columns&buildTypeTab=overview |
labkey-tchad
approved these changes
Oct 1, 2025
Member
labkey-tchad
left a comment
labkey-tchad
left a comment
There was a problem hiding this comment.
Thank you for doing this
Comment on lines
2127
to
2128
| var headersLoc = Locator.id("category-security").descendant(Locator.tagWithClass("th", "group-hdr")); | ||
| return getTexts(headersLoc.findElements(getDriver())).indexOf(column) +1; |
Member
There was a problem hiding this comment.
Consider throwing an exception if the column doesn't exist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This change attempts to address intermittent test failures in SNDTest.categoryPermissionsUI.
The theory of this change is that the order of the columns does not appear to be fixed, but the test references (and asserts) based on hard-coded column indexes. This adds a method in the test to get the column index based on the text of the column header.